[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240208092059.1207134-2-bhargav.r@ltts.com>
Date: Thu, 8 Feb 2024 14:50:57 +0530
From: Bhargav Raviprakash <bhargav.r@...s.com>
To: linux-kernel@...r.kernel.org
Cc: m.nirmaladevi@...s.com,
arnd@...db.de,
gregkh@...uxfoundation.org,
Bhargav Raviprakash <bhargav.r@...s.com>
Subject: [PATCH v1 08/13] misc: tps6594-esm: reversion check limited to TPS6594 family
The reversion check is only applicable on TPS6594 family of PMICs.
Conditionally add that check if the chip_id is one of the PMIC in
the TPS6594 family.
Signed-off-by: Bhargav Raviprakash <bhargav.r@...s.com>
---
drivers/misc/tps6594-esm.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/misc/tps6594-esm.c b/drivers/misc/tps6594-esm.c
index b4d67a1a2..8ec5af9dc 100644
--- a/drivers/misc/tps6594-esm.c
+++ b/drivers/misc/tps6594-esm.c
@@ -45,13 +45,17 @@ static int tps6594_esm_probe(struct platform_device *pdev)
* As a consequence, ESM can not be used on those PMIC.
* Check the version and return an error in case of revision 1.
*/
- ret = regmap_read(tps->regmap, TPS6594_REG_DEV_REV, &rev);
- if (ret)
- return dev_err_probe(dev, ret,
- "Failed to read PMIC revision\n");
- if (rev == TPS6594_DEV_REV_1)
- return dev_err_probe(dev, -ENODEV,
- "ESM not supported for revision 1 PMIC\n");
+ if (tps->chip_id == TPS6594 ||
+ tps->chip_id == TPS6593 ||
+ tps->chip_id == LP8764) {
+ ret = regmap_read(tps->regmap, TPS6594_REG_DEV_REV, &rev);
+ if (ret)
+ return dev_err_probe(dev, ret,
+ "Failed to read PMIC revision\n");
+ if (rev == TPS6594_DEV_REV_1)
+ return dev_err_probe(dev, -ENODEV,
+ "ESM not supported for revision 1 PMIC\n");
+ }
for (i = 0; i < pdev->num_resources; i++) {
irq = platform_get_irq_byname(pdev, pdev->resource[i].name);
--
2.25.1
Powered by blists - more mailing lists