linux-kernel - Re: [PATCH] gpio: remove GPIO device from the list unconditionally in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdzQ9hTo8fG09T4EZDNP9-idTYELoA2uHZYGf=OfxLtFg@mail.gmail.com>
Date: Thu, 8 Feb 2024 10:35:20 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] gpio: remove GPIO device from the list unconditionally in
 error path

On Mon, Feb 5, 2024 at 11:22 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> Since commit 48e1b4d369cf ("gpiolib: remove the GPIO device from the list
> when it's unregistered") we remove the GPIO device entry from the global
> list (used to order devices by their GPIO ranges) when unregistering the
> chip, not when releasing the device. It will not happen when the last
> reference is put anymore. This means, we need to remove it in error path
> in gpiochip_add_data_with_key() unconditionally, without checking if the
> device's .release() callback is set.
>
> Fixes: 48e1b4d369cf ("gpiolib: remove the GPIO device from the list when it's unregistered")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---

Queued for fixes.

Bart