linux-kernel - Re: [PATCH v3 01/32] fpga: ice40-spi: Follow renaming of SPI "master" to "controller"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ofekkoan42mm2v3uf6dc2mjlrzjekjc2k6iaoucrus3yy3e3p@vaco3ina7ohz>
Date: Thu, 8 Feb 2024 11:28:23 +0100
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Tom Rix <trix@...hat.com>, linux-fpga@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>, Moritz Fischer <mdf@...nel.org>, 
	kernel@...gutronix.de, Xu Yilun <yilun.xu@...el.com>, Wu Hao <hao.wu@...el.com>
Subject: Re: [PATCH v3 01/32] fpga: ice40-spi: Follow renaming of SPI
 "master" to "controller"

On Thu, Feb 08, 2024 at 10:09:09AM +0000, Jonathan Cameron wrote:
> On Wed, 7 Feb 2024 19:40:15 +0100
> Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
> 
> > In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"")
> > some functions and struct members were renamed. To not break all drivers
> > compatibility macros were provided.
> > 
> > To be able to remove these compatibility macros push the renaming into
> > this driver.
> > 
> > Acked-by: Xu Yilun <yilun.xu@...el.com>
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Looks like b4 or similar got carried away. I've no objection to any of these
> but the ack was only really meant to be for the IIO one.

Ah, indeed. b4 interpreted your ack as applying to the whole series
because it was given in reply to the cover letter.

If you're indifferent here (and want to improve your ack count :-) I'd
keep it as is. I'd expect that Mark will apply the series, if there
appears a need for a v4 I can drop your Acks again.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)