linux-kernel - Re: linux-next20240208: tg3 driver nw interfaces not getting configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd72544a-f3ed-44bb-86e3-bdfa4fca720e@gmail.com>
Date: Thu, 8 Feb 2024 11:46:47 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: "Aithal, Srikanth" <sraithal@....com>,
 Stephen Rothwell <sfr@...b.auug.org.au>, andrew@...n.ch,
 Jakub Kicinski <kuba@...nel.org>
Cc: Linux Next Mailing List <linux-next@...r.kernel.org>,
 Linux Regressions <regressions@...ts.linux.dev>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: linux-next20240208: tg3 driver nw interfaces not getting
 configured

On 08.02.2024 09:30, Aithal, Srikanth wrote:
> Hi,
> 
> On 6.8.0-rc3-next-20240208, the network interfaces are not getting configured.
> 
Thanks for the report. Could you please elaborate on what "not getting
configured" means in detail?
- Any error in any log?
- Any other error message?
- Interface doesn't come up or which specific configuration are you missing?

> I have 'NetXtreme BCM5720 Gigabit Ethernet PCIe'
>        configuration: autonegotiation=on broadcast=yes driver=tg3
> 
> If I revert below commit I am able to get back the interfaces mentioned.
> 
> commit 9bc791341bc9a5c22b94889aa37993bb69faa317
> Author: Heiner Kallweit <hkallweit1@...il.com>
> Date:   Sat Feb 3 22:12:50 2024 +0100
> 
>     tg3: convert EEE handling to use linkmode bitmaps
> 
>     Convert EEE handling to use linkmode bitmaps. This prepares for
>     removing the legacy bitmaps from struct ethtool_keee.
>     No functional change intended.
> 
>     Note: The change to mii_eee_cap1_mod_linkmode_t(tp->eee.advertised, val)
>     in tg3_phy_autoneg_cfg() isn't completely obvious, but it doesn't change
>     the current functionality.
> 
>     Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>     Reviewed-by: Andrew Lunn <andrew@...n.ch>
>     Link: https://lore.kernel.org/r/0652b910-6bcc-421f-8769-38f7dae5037e@gmail.com
>     Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> 
> 
> The same works fine on 6.8.0-rc3-next-20240207.
> 
> Thanks,
> Srikanth Aithal
> sraithal@....com
Heiner