linux-kernel - Re: [PATCH v6 0/2] lib: checksum: Fix issues with checksum tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240207174522.2d19729ec2e014d521335a04@linux-foundation.org>
Date: Wed, 7 Feb 2024 17:45:22 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Charlie Jenkins <charlie@...osinc.com>
Cc: Guenter Roeck <linux@...ck-us.net>, David Laight
 <David.Laight@...lab.com>, Palmer Dabbelt <palmer@...belt.com>,
 linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v6 0/2] lib: checksum: Fix issues with checksum tests

On Wed, 07 Feb 2024 16:22:49 -0800 Charlie Jenkins <charlie@...osinc.com> wrote:

> The ip_fast_csum and csum_ipv6_magic tests did not have the data
> types properly casted, and improperly misaligned data.

Neither this nor the two patch's changelogs describe *why* these changes
are needed.  They merely assert that we need to do this.

IOW, when fixing a bug please always describe the user-visible effects
of that bug.