linux-kernel - Re: [PATCH v1 1/2] leds: aw200xx: support for hw pattern controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240208135918.GQ689448@google.com>
Date: Thu, 8 Feb 2024 13:59:18 +0000
From: Lee Jones <lee@...nel.org>
To: Dmitry Rokosov <ddrokosov@...utedevices.com>
Cc: Pavel Machek <pavel@....cz>,
	Martin Kurbanov <mmkurbanov@...utedevices.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	kernel@...utedevices.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v1 1/2] leds: aw200xx: support for hw pattern controllers

On Mon, 29 Jan 2024, Dmitry Rokosov wrote:

> Hello Pavel,
> 
> On Sat, Jan 27, 2024 at 12:21:48AM +0100, Pavel Machek wrote:
> > Hi!
> > 
> > > > This led-controller supports 3 pattern controllers for auto breathing or
> > > > group dimming control. Each pattern controller can work in auto
> > > > breathing or manual control mode. All breathing parameters including
> > > > rising/falling slope, on/off time, repeat times, min/max brightness
> > > > and so on are configurable.
> > > > 
> > > > Signed-off-by: Martin Kurbanov <mmkurbanov@...utedevices.com>
> > > > ---
> > > >  .../testing/sysfs-class-led-driver-aw200xx    | 108 +++
> > > >  Documentation/leds/leds-aw200xx.rst           | 274 ++++++++
> > > >  drivers/leds/leds-aw200xx.c                   | 649 ++++++++++++++++++
> > > >  3 files changed, 1031 insertions(+)
> > > >  create mode 100644 Documentation/leds/leds-aw200xx.rst
> > > 
> > > This interface is bananas.  Exposing an entire register interface to
> > > sysfs does not sit will with me at all.  When we add support to a sysfs
> > > class, we usually require it to be generic and work across all devices.
> > > Adding device specific interfaces is generally decried and to be
> > > avoided.  Don't forget, once we commit something to sysfs, it becomes
> > > ABI and we have to support it forever.
> > 
> > If you do git grep hw_pattern, you should get pointers to qcom-lpg
> > driver that solves similar problem, with interface that should be
> > acceptable.
> 
> Thank you for pointing that out. Yes, it's a very similar situation to
> ours.
> 
> But I haven't observed the merging of this driver. Was it encountering
> similar issues with the sysfs interface?

`git grep` kinda implies that it's merged.

-- 
Lee Jones [李琼斯]