[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <2f280707-7250-4bb2-460c-5f8a02208179@linux.intel.com>
Date: Thu, 8 Feb 2024 17:11:23 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Vishnu Sankar <vishnuocv@...il.com>
cc: Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>, vsankar@...ovo.com,
Mark Pearson <mpearson-lenovo@...ebb.ca>
Subject: Re: [PATCH] Fix to correct wrong temp reporting on some ThinkPads
On Thu, 8 Feb 2024, Vishnu Sankar wrote:
> Thanks a lot for the review.
> And sorry for the delay in response.
Small improvements to my earlier version below now that I reread it.
> On Tue, Feb 6, 2024 at 8:03 PM Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> wrote:
>
> > @@ -6174,6 +6191,21 @@ static int thermal_get_sensor(int idx, s32 *value)
...
> A code reader would be served much better if this convoluted logic is
> simplied to:
>
> case TPACPI_THERMAL_TPEC_12:
> if (idx >= 12)
> return -EINVAL;
>
> if (idx <= 7)
if (idx < 8) <- to match idx - 8
> ec_offset = TP_EC_THERMAL_TMP0_NS + idx;
> else
> ec_offset = TP_EC_THERMAL_TMP8_NS + (idx - 8);
>
> if (!acpi_ec_read(ec_offset, &tmp))
> return -EIO;
>
> *value = tmp * 1000;
1000 should likely be something from linux/units.h.
--
i.
Powered by blists - more mailing lists