linux-kernel - Re: [PATCH v4 5/5] sched: rename SD_SHARE_PKG_RESOURCES to SD_SHARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xhsmhv86zf0gt.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Date: Thu, 08 Feb 2024 16:18:58 +0100
From: Valentin Schneider <vschneid@...hat.com>
To: alexs@...nel.org, Christophe Leroy <christophe.leroy@...roup.eu>,
 "Aneesh Kumar K . V" <aneesh.kumar@...nel.org>, "Naveen N . Rao"
 <naveen.n.rao@...ux.ibm.com>, Ingo Molnar <mingo@...hat.com>, Juri Lelli
 <juri.lelli@...hat.com>, Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
 Daniel Bristot de Oliveira <bristot@...hat.com>, Frederic Weisbecker
 <frederic@...nel.org>, Mark Rutland <mark.rutland@....com>, Barry Song
 <song.bao.hua@...ilicon.com>, Miaohe Lin <linmiaohe@...wei.com>,
 linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc: Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin
 <npiggin@...il.com>, Srikar Dronamraju <srikar@...ux.vnet.ibm.com>, Josh
 Poimboeuf <jpoimboe@...nel.org>, Alex Shi <alexs@...nel.org>, Ricardo Neri
 <ricardo.neri-calderon@...ux.intel.com>, Yicong Yang
 <yangyicong@...ilicon.com>, "Gautham R . Shenoy" <gautham.shenoy@....com>
Subject: Re: [PATCH v4 5/5] sched: rename SD_SHARE_PKG_RESOURCES to
 SD_SHARE_LLC

On 07/02/24 11:58, alexs@...nel.org wrote:
> From: Alex Shi <alexs@...nel.org>
>
> SD_CLUSTER shares the CPU resources like llc tags or l2 cache, that's
> easy confuse with SD_SHARE_PKG_RESOURCES. So let's specifical point
> what the latter shares: LLC. That would reduce some confusing.
>
> Suggested-by: Valentin Schneider <vschneid@...hat.com>
> Signed-off-by: Alex Shi <alexs@...nel.org>

AFAICT it's just missing the below replacement (I've stretched the comments
to go up to 80 chars while at it), otherwise LGTM.

Reviewed-by: Valentin Schneider <vschneid@...hat.com>

---

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index e877730219d38..99ea5986038ce 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -657,13 +657,13 @@ static void destroy_sched_domains(struct sched_domain *sd)
 }

 /*
- * Keep a special pointer to the highest sched_domain that has
- * SD_SHARE_PKG_RESOURCE set (Last Level Cache Domain) for this
- * allows us to avoid some pointer chasing select_idle_sibling().
+ * Keep a special pointer to the highest sched_domain that has SD_SHARE_LLC set
+ * (Last Level Cache Domain) for this allows us to avoid some pointer chasing
+ * select_idle_sibling().
  *
- * Also keep a unique ID per domain (we use the first CPU number in
- * the cpumask of the domain), this allows us to quickly tell if
- * two CPUs are in the same cache domain, see cpus_share_cache().
+ * Also keep a unique ID per domain (we use the first CPU number in the cpumask
+ * of the domain), this allows us to quickly tell if two CPUs are in the same
+ * cache domain, see cpus_share_cache().
  */
 DEFINE_PER_CPU(struct sched_domain __rcu *, sd_llc);
 DEFINE_PER_CPU(int, sd_llc_size);