linux-kernel - Re: [PATCH v2 5/5] sched/vtime: do not include <asm/vtime.h> header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CZ08GUY1Y35T.2U33WWSJN7JVH@wheely>
Date: Fri, 09 Feb 2024 13:38:01 +1000
From: "Nicholas Piggin" <npiggin@...il.com>
To: "Alexander Gordeev" <agordeev@...ux.ibm.com>, "Frederic Weisbecker"
 <frederic@...nel.org>, "Ingo Molnar" <mingo@...nel.org>, "Michael Ellerman"
 <mpe@...erman.id.au>, "Heiko Carstens" <hca@...ux.ibm.com>, "Vasily Gorbik"
 <gor@...ux.ibm.com>
Cc: <linux-kernel@...r.kernel.org>, <linux-s390@...r.kernel.org>,
 <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH v2 5/5] sched/vtime: do not include <asm/vtime.h> header

On Fri Feb 9, 2024 at 6:15 AM AEST, Alexander Gordeev wrote:
> There is no architecture-specific code or data left
> that generic <linux/vtime.h> needs to know about.
> Thus, avoid the inclusion of <asm/vtime.h> header.

Nice cleanup!

Acked-by: Nicholas Piggin <npiggin@...il.com>

>
> Reviewed-by: Frederic Weisbecker <frederic@...nel.org>
> Signed-off-by: Alexander Gordeev <agordeev@...ux.ibm.com>
> ---
>  arch/powerpc/include/asm/Kbuild | 1 -
>  include/asm-generic/vtime.h     | 1 -
>  include/linux/vtime.h           | 4 ----
>  3 files changed, 6 deletions(-)
>  delete mode 100644 include/asm-generic/vtime.h
>
> diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
> index 61a8d5555cd7..e5fdc336c9b2 100644
> --- a/arch/powerpc/include/asm/Kbuild
> +++ b/arch/powerpc/include/asm/Kbuild
> @@ -6,5 +6,4 @@ generic-y += agp.h
>  generic-y += kvm_types.h
>  generic-y += mcs_spinlock.h
>  generic-y += qrwlock.h
> -generic-y += vtime.h
>  generic-y += early_ioremap.h
> diff --git a/include/asm-generic/vtime.h b/include/asm-generic/vtime.h
> deleted file mode 100644
> index b1a49677fe25..000000000000
> --- a/include/asm-generic/vtime.h
> +++ /dev/null
> @@ -1 +0,0 @@
> -/* no content, but patch(1) dislikes empty files */
> diff --git a/include/linux/vtime.h b/include/linux/vtime.h
> index 593466ceebed..29dd5b91dd7d 100644
> --- a/include/linux/vtime.h
> +++ b/include/linux/vtime.h
> @@ -5,10 +5,6 @@
>  #include <linux/context_tracking_state.h>
>  #include <linux/sched.h>
>  
> -#ifdef CONFIG_VIRT_CPU_ACCOUNTING_NATIVE
> -#include <asm/vtime.h>
> -#endif
> -
>  /*
>   * Common vtime APIs
>   */