linux-kernel - Re: [PATCH] rust: locks: Add `get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e847145b-f837-4110-8f93-806b7101d7b6@ryhl.io>
Date: Fri, 9 Feb 2024 20:44:11 +0100
From: Alice Ryhl <alice@...l.io>
To: mathys35.gasnier@...il.com
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng
 <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...sung.com>, Alice Ryhl <aliceryhl@...gle.com>
Subject: Re: [PATCH] rust: locks: Add `get_mut` method to `Lock`

On 2/9/24 17:22, Mathys-Gasnier via B4 Relay wrote:
> From: Mathys-Gasnier <mathys35.gasnier@...il.com>
> 
> Having a mutable reference guarantees that no other threads have
> access to the lock, so we can take advantage of that to grant callers
> access to the protected data without the the cost of acquiring and
> releasing the locks. Since the lifetime of the data is tied to the
> mutable reference, the borrow checker guarantees that the usage is safe.
> 
> Signed-off-by: Mathys-Gasnier <mathys35.gasnier@...il.com>
> ---
>   rust/kernel/sync/lock.rs | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/rust/kernel/sync/lock.rs b/rust/kernel/sync/lock.rs
> index f12a684bc957..7711c6313e14 100644
> --- a/rust/kernel/sync/lock.rs
> +++ b/rust/kernel/sync/lock.rs
> @@ -121,6 +121,11 @@ pub fn lock(&self) -> Guard<'_, T, B> {
>           // SAFETY: The lock was just acquired.
>           unsafe { Guard::new(self, state) }
>       }
> +
> +    /// Gets the data contained in the lock
> +    pub fn get_mut(&mut self) -> &mut T {
> +        self.data.get_mut()
> +    }

You can never have a mutable reference to a Linux mutex because we pin 
our locks. At most, you can have a Pin<&mut Self>.

Alice