linux-kernel - Re: [PATCH v14 01/53] xhci: fix possible null pointer dereference at secondary interrupter removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 9 Feb 2024 12:16:59 -0800
From: Wesley Cheng <quic_wcheng@...cinc.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: <srinivas.kandagatla@...aro.org>, <mathias.nyman@...el.com>,
        <perex@...ex.cz>, <conor+dt@...nel.org>, <corbet@....net>,
        <lgirdwood@...il.com>, <andersson@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <Thinh.Nguyen@...opsys.com>,
        <broonie@...nel.org>, <bgoswami@...cinc.com>, <tiwai@...e.com>,
        <robh+dt@...nel.org>, <konrad.dybcio@...aro.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-sound@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-doc@...r.kernel.org>,
        <alsa-devel@...a-project.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH v14 01/53] xhci: fix possible null pointer dereference at
 secondary interrupter removal

Hi Greg,

On 2/9/2024 2:22 AM, Greg KH wrote:
> On Thu, Feb 08, 2024 at 03:13:14PM -0800, Wesley Cheng wrote:
>> From: Mathias Nyman <mathias.nyman@...ux.intel.com>
>>
>> Don't try to remove a secondary interrupter that is known to be invalid.
>> Also check if the interrupter is valid inside the spinlock that protects
>> the array of interrupters.
>>
>> Found by smatch static checker
>>
>> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
>> Closes: https://lore.kernel.org/linux-usb/ffaa0a1b-5984-4a1f-bfd3-9184630a97b9@moroto.mountain/
>> Fixes: c99b38c41234 ("xhci: add support to allocate several interrupters")
>> Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
>> Link: https://lore.kernel.org/r/20240125152737.2983959-2-mathias.nyman@linux.intel.com
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Wesley Cheng <quic_wcheng@...cinc.com>
> 
> Wait, this is already in my tree, right?  Why keep sending it?
> 

Sorry, I noticed this yesterday night as well when I was preparing some 
changes to push elsewhere.  Will remove the ones I saw that were already 
present on usb-next.

Thanks
Wesley Cheng