linux-kernel - Re: [PATCH] regmap: kunit: Ensure that changed bytes are actually different

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZcadHAEN1N0DwR5w@finisterre.sirena.org.uk>
Date: Fri, 9 Feb 2024 21:46:04 +0000
From: Mark Brown <broonie@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: kunit: Ensure that changed bytes are actually
 different

On Fri, Feb 09, 2024 at 01:25:36PM -0800, Guenter Roeck wrote:

> +       get_changed_bytes(&hw_buf[4], &val[0], sizeof(val));
> +       // Let's cheat.
> +       // Remember, the above code doesn't look into hw_buf[2..3],
> +       // so anything might be in there, including the values from
> +       // the val[] array.
> +       hw_buf[2] = val[0];
> +       hw_buf[3] = val[1];

Ugh, yeah - I'm paying attention to too many things at once today I
fear.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)