linux-kernel - Re: [PATCH v3 02/13] security: Introduce the digest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8378ba2-ccd1-48fe-973d-38986fc0716d@infradead.org>
Date: Fri, 9 Feb 2024 15:00:44 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Roberto Sassu <roberto.sassu@...weicloud.com>, corbet@....net,
 paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com, shuah@...nel.org,
 mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com, mic@...ikod.net
Cc: linux-security-module@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 bpf@...r.kernel.org, zohar@...ux.ibm.com, dmitry.kasatkin@...il.com,
 linux-integrity@...r.kernel.org, wufan@...ux.microsoft.com,
 pbrobinson@...il.com, zbyszek@...waw.pl, hch@....de, mjg59@...f.ucam.org,
 pmatilai@...hat.com, jannh@...gle.com, dhowells@...hat.com,
 jikos@...nel.org, mkoutny@...e.com, ppavlu@...e.com, petr.vorel@...il.com,
 petrtesarik@...weicloud.com, Roberto Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH v3 02/13] security: Introduce the digest_cache LSM

Hi--

On 2/9/24 06:09, Roberto Sassu wrote:
> diff --git a/security/digest_cache/Kconfig b/security/digest_cache/Kconfig
> new file mode 100644
> index 000000000000..0c47d5151f07
> --- /dev/null
> +++ b/security/digest_cache/Kconfig
> @@ -0,0 +1,17 @@
> +# SPDX-License-Identifier: GPL-2.0
> +config SECURITY_DIGEST_CACHE
> +	bool "Digest_cache LSM"
> +	default n
> +	help
> +	   This option enables an LSM maintaining a cache of digests
> +	   (e.g. of file content or metadata).
> +
> +	   This LSM can support other kernel components in making access
> +	   control decisions.
> +

nit:  -ESTYLE.
coding-style.rst says:

Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.

> +config DIGEST_LIST_DEFAULT_PATH
> +	string
> +	default "/etc/digest_lists"
> +	help
> +	   Default directory where digest_cache LSM expects to find digest
> +	   lists.

Same comment for patch 03/13.
Same comment for patch 04/13.

-- 
#Randy