linux-kernel - [PATCH 1/1] tools/objtools: tolerate mix of data in code section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240209235231.889839-2-saeed.mirzamohammadi@oracle.com>
Date: Fri,  9 Feb 2024 15:52:30 -0800
From: Saeed Mirzamohammadi <saeed.mirzamohammadi@...cle.com>
To: 
Cc: jpoimboe@...nel.org, peterz@...radead.org, linux-kernel@...r.kernel.org,
        saeed.mirzamohammadi@...cle.com
Subject: [PATCH 1/1] tools/objtools: tolerate mix of data in code section

Hand-written asm files might have data in the .text section and this
causes the objtools to not find the starting instruction. This avoids
this warning.

warning: objtool: n8_SafeDecrypt_RIJ128(): can't find starting instruction

Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@...cle.com>
---
 tools/objtool/check.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index e308d1ba664ef..9de4881f16984 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -459,9 +459,11 @@ static int decode_instructions(struct objtool_file *file)
 				continue;
 
 			if (!find_insn(file, sec, func->offset)) {
-				WARN("%s(): can't find starting instruction",
-				     func->name);
-				return -1;
+				/*
+				 * Can't find starting instruction likely due to data in
+				 * beginning of the section
+				 */
+				continue;
 			}
 
 			sym_for_each_insn(file, func, insn) {
-- 
2.42.0