linux-kernel - Re: [PATCH] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 9 Feb 2024 06:31:15 +0000
From: <Dharma.B@...rochip.com>
To: <conor@...nel.org>, <robh@...nel.org>
CC: <alexandre.belloni@...tlin.com>, <conor+dt@...nel.org>,
	<linux-kernel@...r.kernel.org>, <tglx@...utronix.de>,
	<Nicolas.Ferre@...rochip.com>, <linux-arm-kernel@...ts.infradead.org>,
	<robh+dt@...nel.org>, <claudiu.beznea@...on.dev>,
	<devicetree@...r.kernel.org>, <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Convert Atmel AIC to
 json-schema

Hi Conor,

On 09/02/24 12:19 am, Conor Dooley wrote:
> Hey Dharma,
> 
> On Thu, Feb 08, 2024 at 03:51:31PM +0000, Rob Herring wrote:
>> On Thu, 08 Feb 2024 14:50:15 +0530, Dharma Balasubiramani wrote:
>>> Convert the Atmel AIC binding document to DT schema format using
>>> json-schema.
>>>
>>> Signed-off-by: Dharma Balasubiramani<dharma.b@...rochip.com>
>>> ---
>>> Note: I get the following warnings on latest kernel but not in 6.7.
>>> Should I be worried?
>>> usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR [FILE_OR_DIR ...]]
>>> yamllint: error: one of the arguments FILE_OR_DIR - is required
> Hard to say, how were you envoking the command? There were some issues
> recently with dt_binding_check, but I thought those had been fixed.

I use this command to validate

make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- dt_binding_check 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml

and also dtbs_check.

version = yamllint 1.32.0
> 
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/interrupt-controller/atmel,aic.example.dtb: /example-1/dma-controller@...fec00: failed to match any schema with compatible: ['atmel,at91sam9g45-dma']
> But you didn't see this warning?

No I didn't see this warning when applied on tag:6.7. Don't know why.

> I think you can resolve it by just dropping the "user" example from the
> binding entirely. I don't think it adds anything at all.

I intentionally checked the generated example dts file and found that 
both the examples look correct.

     example-0 {
         #address-cells = <1>;
         #size-cells = <1>;

         /* AIC */
         aic: interrupt-controller@...ff000 {
           compatible = "atmel,at91rm9200-aic";
           interrupt-controller;
           #interrupt-cells = <3>;
           reg = <0xfffff000 0x200>;
           atmel,external-irqs = <31>;
         };

     };

     example-1 {
         #address-cells = <1>;
         #size-cells = <1>;

         interrupt-parent = <&fake_intc1>;
         fake_intc1: fake-interrupt-controller {
             interrupt-controller;
             #interrupt-cells = < 3 >;
         };

         /* An interrupt generating device that is wired to an AIC. */
         dma: dma-controller@...fec00 {
           compatible = "atmel,at91sam9g45-dma";
           #dma-cells = <2>;
           reg = <0xffffec00 0x200>;
           interrupts = <21 4 5>;
         };

     };

> 
> Cheers,
> Conor.

Please correct me if I'm doing something wrong here.

-- 
With Best Regards,
Dharma B.