linux-kernel - Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87il2yaww9.fsf@intel.com>
Date: Fri, 09 Feb 2024 10:01:58 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Lucas De Marchi <lucas.demarchi@...el.com>, Andi Shyti
 <andi.shyti@...ux.intel.com>
Cc: Yury Norov <yury.norov@...il.com>, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, intel-xe@...ts.freedesktop.org,
 intel-gfx@...ts.freedesktop.org
Subject: Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT

On Thu, 08 Feb 2024, Lucas De Marchi <lucas.demarchi@...el.com> wrote:
> On Thu, Feb 08, 2024 at 09:04:45PM +0100, Andi Shyti wrote:
>>Hi Lucas,
>>
>>looks good, just one idea...
>>
>>...
>>
>>> +#define BIT_U8(b)		((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b)))
>>> +#define BIT_U16(b)		((u16)(BIT_INPUT_CHECK(u16, b) + BIT(b)))
>>> +#define BIT_U32(b)		((u32)(BIT_INPUT_CHECK(u32, b) + BIT(b)))
>>> +#define BIT_U64(b)		((u64)(BIT_INPUT_CHECK(u64, b) + BIT(b)))
>>
>>considering that BIT defines are always referred to unsigned
>>types, I would just call them
>>
>>#define BIT8
>>#define BIT16
>>#define BIT32
>>#define BIT64
>>
>>what do you think?
>
> it will clash with defines from other headers and not match the ones for
> GENMASK  so I prefer it the other way.

Agreed.


-- 
Jani Nikula, Intel