linux-kernel - Re: [syzbot] [media?] possible deadlock in v4l2_ctrl_handler_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri,  9 Feb 2024 16:11:27 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+9948f8e188482c5d1a3e@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [media?] possible deadlock in v4l2_ctrl_handler_log_status

On Thu, 08 Feb 2024 01:17:28 -0800
> HEAD commit:    b1d3a0e70c38 Add linux-next specific files for 20240208
> git tree:       linux-next
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1746f9b7e80000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git  master

--- x/drivers/media/v4l2-core/v4l2-ctrls-core.c
+++ y/drivers/media/v4l2-core/v4l2-ctrls-core.c
@@ -2550,7 +2550,7 @@ void v4l2_ctrl_handler_log_status(struct
 		colon = ": ";
 	mutex_lock(hdl->lock);
 	list_for_each_entry(ref, &hdl->ctrl_refs, node) {
-		if (ref->from_other_dev ||
+		if (ref->from_other_dev || ref->ctrl->handler != hdl ||
 		    (ref->ctrl->flags & V4L2_CTRL_FLAG_DISABLED))
 			continue;
 		log_ctrl(hdl, ref->ctrl, prefix, colon);
--