[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAH5fLghObExCR55dEozb2MSsPZWd7432z5FyOYmNKHFKJHt8Lg@mail.gmail.com>
Date: Fri, 9 Feb 2024 12:15:48 +0100
From: Alice Ryhl <aliceryhl@...gle.com>
To: Valentin Obst <kernel@...entinobst.de>
Cc: a.hindborg@...sung.com, akpm@...ux-foundation.org, alex.gaynor@...il.com,
arnd@...db.de, arve@...roid.com, benno.lossin@...ton.me,
bjorn3_gh@...tonmail.com, boqun.feng@...il.com, brauner@...nel.org,
cmllamas@...gle.com, gary@...yguo.net, gregkh@...uxfoundation.org,
joel@...lfernandes.org, keescook@...omium.org, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, maco@...roid.com, ojeda@...nel.org,
rust-for-linux@...r.kernel.org, surenb@...gle.com, tkjos@...roid.com,
viro@...iv.linux.org.uk, wedsonaf@...il.com
Subject: Re: [PATCH v2 1/4] rust: uaccess: add userspace pointers
On Thu, Feb 8, 2024 at 11:54 PM Valentin Obst <kernel@...entinobst.de> wrote:
>
> > + /// Reads the entirety of the user slice, appending it to the end of the
> > + /// provided buffer.
> > + ///
> > + /// Fails with `EFAULT` if the read encounters a page fault.
> > + pub fn read_all(self, buf: &mut Vec<u8>) -> Result<()> {
> > + self.reader().read_all(buf)
> > + }
>
> I think there is also no need to give an explicit `()` for the
> generic type parameter here as it is the default (applies to some
> other methods in this patch as well).
I'll change this if I send a v3, but I don't think it's that important.
Alice
Powered by blists - more mailing lists