linux-kernel - Re: [PATCH 0/6] mfd: tmio: simplify header and move to platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 9 Feb 2024 13:28:37 +0000
From: Lee Jones <lee@...nel.org>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
	linux-renesas-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH 0/6] mfd: tmio: simplify header and move to platform_data

On Fri, 09 Feb 2024, Ulf Hansson wrote:

> On Fri, 9 Feb 2024 at 02:59, Wolfram Sang
> <wsa+renesas@...g-engineering.com> wrote:
> >
> > The MFD parts of the TMIO have been removed by Arnd, so that only the
> > SD/MMC related functionality is left. Remove the outdated remains in the
> > public header file and then move it to platform_data as the data is now
> > specific for the SD/MMC part.
> >
> > Based on 6.8-rc3, build bot is happy. Branch is here:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tmio-simplification
> >
> > I'd suggest this goes via the MFD tree, so the series would need acks
> > from the MMC and SH maintainers. Is that okay with everyone?
> 
> Wouldn't it be better to funnel this via the mmc tree? In that way, we
> can easily avoid conflicts with additional renesas-mmc driver changes
> that we have in pipe.

You could say the same about changes SH, MFD and Platform Data have in
the pipe.

> Or perhaps there are other changes that make the mfd tree preferred?

MFD is usually preferred since the parent device usually lives there and
we are well accustomed to merging multi-subsystem related sets.

It doesn't really matter how this is merged.  The only stipulation is
that whoever applies the set does so on a succinct, immutable, tagged
branch and sends out a pull-request for everyone else to pull from.

If you want to do that, there are no complains from me.

> > All the best!
> >
> >    Wolfram
> >
> >
> > Wolfram Sang (6):
> >   mfd: tmio: remove obsolete platform_data
> >   mfd: tmio: remove obsolete io accessors
> >   mmc: tmio/sdhi: fix includes
> >   mfd: tmio: update include files
> >   mfd: tmio: sanitize comments
> >   mfd: tmio: move header to platform_data
> >
> >  MAINTAINERS                                   |   2 +-
> >  arch/sh/boards/board-sh7757lcr.c              |   2 +-
> >  arch/sh/boards/mach-ap325rxa/setup.c          |   2 +-
> >  arch/sh/boards/mach-ecovec24/setup.c          |   2 +-
> >  arch/sh/boards/mach-kfr2r09/setup.c           |   2 +-
> >  arch/sh/boards/mach-migor/setup.c             |   2 +-
> >  arch/sh/boards/mach-se/7724/setup.c           |   2 +-
> >  drivers/mmc/host/renesas_sdhi_core.c          |   2 +-
> >  drivers/mmc/host/renesas_sdhi_internal_dmac.c |   5 +-
> >  drivers/mmc/host/renesas_sdhi_sys_dmac.c      |   5 +-
> >  drivers/mmc/host/tmio_mmc_core.c              |   3 +-
> >  drivers/mmc/host/uniphier-sd.c                |   2 +-
> >  include/linux/mfd/tmio.h                      | 133 ------------------
> >  include/linux/platform_data/tmio.h            |  64 +++++++++
> >  14 files changed, 81 insertions(+), 147 deletions(-)
> >  delete mode 100644 include/linux/mfd/tmio.h
> >  create mode 100644 include/linux/platform_data/tmio.h
> >
> > --
> > 2.43.0
> >
> >

-- 
Lee Jones [李琼斯]