linux-kernel - Re: linux-next20240208: tg3 driver nw interfaces not getting configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6aa4c396-00f2-4479-8ea9-fa67253ee662@lunn.ch>
Date: Fri, 9 Feb 2024 14:39:52 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: "Aithal, Srikanth" <sraithal@....com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Jakub Kicinski <kuba@...nel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>,
	Linux Regressions <regressions@...ts.linux.dev>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: linux-next20240208: tg3 driver nw interfaces not getting
 configured

> Could you please test whether the following fixes the issue for you?
> 
> The uninitialized struct ethtool_keee causes the bug because
> mii_eee_cap1_mod_linkmode_t() leaves unknown bits as-is.
> 
> ---
>  drivers/net/ethernet/broadcom/tg3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 50f674031..7d0a2f5f3 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -4616,7 +4616,7 @@ static int tg3_init_5401phy_dsp(struct tg3 *tp)
>  
>  static bool tg3_phy_eee_config_ok(struct tg3 *tp)
>  {
> -	struct ethtool_keee eee;
> +	struct ethtool_keee eee = {};

Nice catch.

Please add my Reviewed-by, if you have not already sent the real
patch.

	Andrew