linux-kernel - RE: [PATCH] drm/amd/display: Fix && vs || typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR12MB4545EFF1E303FE549FFF06DAF34B2@DM6PR12MB4545.namprd12.prod.outlook.com>
Date: Fri, 9 Feb 2024 14:12:15 +0000
From: "Koo, Anthony" <Anthony.Koo@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>, "SHANMUGAM, SRINIVASAN"
	<SRINIVASAN.SHANMUGAM@....com>
CC: "Wentland, Harry" <Harry.Wentland@....com>, "Li, Sun peng (Leo)"
	<Sunpeng.Li@....com>, "Siqueira, Rodrigo" <Rodrigo.Siqueira@....com>,
	"Deucher, Alexander" <Alexander.Deucher@....com>, "Koenig, Christian"
	<Christian.Koenig@....com>, "Pan, Xinhui" <Xinhui.Pan@....com>, David Airlie
	<airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, "Kazlauskas, Nicholas"
	<Nicholas.Kazlauskas@....com>, "Pavic, Josip" <Josip.Pavic@....com>, "Huang,
 Leon" <Leon.Huang1@....com>, "Adhuri, Mounika" <Mounika.Adhuri@....com>,
	"Huang, Lewis" <Lewis.Huang@....com>, "amd-gfx@...ts.freedesktop.org"
	<amd-gfx@...ts.freedesktop.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] drm/amd/display: Fix && vs || typos

[AMD Official Use Only - General]

Reviewed-by: Anthony Koo <Anthony.Koo@....com>

Looks good, my mistake for not noticing this!

Thanks,
Anthony

-----Original Message-----
From: Dan Carpenter <dan.carpenter@...aro.org>
Sent: Friday, February 9, 2024 8:03 AM
To: SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@....com>
Cc: Wentland, Harry <Harry.Wentland@....com>; Li, Sun peng (Leo) <Sunpeng.Li@....com>; Siqueira, Rodrigo <Rodrigo.Siqueira@....com>; Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian <Christian.Koenig@....com>; Pan, Xinhui <Xinhui.Pan@....com>; David Airlie <airlied@...il.com>; Daniel Vetter <daniel@...ll.ch>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@....com>; Koo, Anthony <Anthony.Koo@....com>; Pavic, Josip <Josip.Pavic@....com>; Huang, Leon <Leon.Huang1@....com>; Adhuri, Mounika <Mounika.Adhuri@....com>; Huang, Lewis <Lewis.Huang@....com>; amd-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
Subject: [PATCH] drm/amd/display: Fix && vs || typos

These ANDs should be ORs or it will lead to a NULL dereference.

Fixes: fb5a3d037082 ("drm/amd/display: Add NULL test for 'timing generator' in 'dcn21_set_pipe()'")
Fixes: 886571d217d7 ("drm/amd/display: Fix 'panel_cntl' could be null in 'dcn21_set_backlight_level()'")
Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
---
 drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
index 5c7f380a84f9..7252f5f781f0 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn21/dcn21_hwseq.c
@@ -211,7 +211,7 @@ void dcn21_set_pipe(struct pipe_ctx *pipe_ctx)
        struct dmcu *dmcu = pipe_ctx->stream->ctx->dc->res_pool->dmcu;
        uint32_t otg_inst;

-       if (!abm && !tg && !panel_cntl)
+       if (!abm || !tg || !panel_cntl)
                return;

        otg_inst = tg->inst;
@@ -245,7 +245,7 @@ bool dcn21_set_backlight_level(struct pipe_ctx *pipe_ctx,
        struct panel_cntl *panel_cntl = pipe_ctx->stream->link->panel_cntl;
        uint32_t otg_inst;

-       if (!abm && !tg && !panel_cntl)
+       if (!abm || !tg || !panel_cntl)
                return false;

        otg_inst = tg->inst;
--
2.43.0