linux-kernel - Re: [PATCH] drm/tests: mm: Convert to drm_dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o7cpad82.fsf@intel.com>
Date: Fri, 09 Feb 2024 17:06:53 +0200
From: Jani Nikula <jani.nikula@...el.com>
To: Michał Winiarski <michal.winiarski@...el.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David
 Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Luca Coelho
 <luciano.coelho@...el.com>, Michał Winiarski
 <michal.winiarski@...el.com>
Subject: Re: [PATCH] drm/tests: mm: Convert to drm_dbg_printer

On Fri, 09 Feb 2024, Michał Winiarski <michal.winiarski@...el.com> wrote:
> Fix one of the tests in drm_mm that was not converted prior to
> drm_debug_printer removal, causing tests build failure.

My bad, thanks for fixing this.

Reviewed-by: Jani Nikula <jani.nikula@...el.com>

For one thing, I must not have git grep'd for new drm_debug_printer()
additions since I wrote the patch.

For another, I'm missing some kernel config, because I built the changes
on x86, arm and arm64 before pushing. In particular the arm and arm64
configs I just recently added from drm-rerere repo. Those defconfigs
should probably be updated. They don't have CONFIG_DRM_XE=m either.

BR,
Jani.

>
> Fixes: e154c4fc7bf2d ("drm: remove drm_debug_printer in favor of drm_dbg_printer")
> Signed-off-by: Michał Winiarski <michal.winiarski@...el.com>
> ---
>  drivers/gpu/drm/tests/drm_mm_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c
> index 1eb0c304f9607..3488d930e3a38 100644
> --- a/drivers/gpu/drm/tests/drm_mm_test.c
> +++ b/drivers/gpu/drm/tests/drm_mm_test.c
> @@ -188,7 +188,7 @@ static void drm_test_mm_init(struct kunit *test)
>  
>  static void drm_test_mm_debug(struct kunit *test)
>  {
> -	struct drm_printer p = drm_debug_printer(test->name);
> +	struct drm_printer p = drm_dbg_printer(NULL, DRM_UT_CORE, test->name);
>  	struct drm_mm mm;
>  	struct drm_mm_node nodes[2];

-- 
Jani Nikula, Intel