linux-kernel - Re: [PATCH] iommu/amd: Mark interrupt as managed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 9 Feb 2024 09:48:57 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Joerg Roedel <joro@...tes.org>
Cc: suravee.suthikulpanit@....com, Vasant.Hegde@....com, will@...nel.org,
 robin.murphy@....com, iommu@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/amd: Mark interrupt as managed

On 2/9/2024 02:24, Joerg Roedel wrote:
> Hi Mario,
> 
> On Mon, Feb 05, 2024 at 10:31:47AM -0600, Mario Limonciello wrote:
>> Friendly ping on reviewing this patch.
> 
> Thanks for the patch. Since this is a fix the patch should contain a
> Fixes: tag. Also a review from Suravee and/or Vasant would be great.
> 
> Thanks,
> 
> 	Joerg
> 

Thanks!  This problem should go all the way to when MSI support was 
introduced (2.6.28):

a80dc3e0e0dc ("AMD IOMMU: add MSI interrupt support")

But I don't think that's a correct fixes tag because
irq_managed wasn't introduced until 3.19:

cffe0a2b5a34 ("x86, irq: Keep balance of IOAPIC pin reference count")

But then I tried to go off the original introduction of the error 
message, but that's quite ancient.

1da177e4c3f4 ("Linux-2.6.12-rc2")

So which tag do you think is appropriate to use?  I'm tempted to say 
this should just be without a fixes tag just a:

Cc: stable@...r.kernel.org # 3.19+