linux-kernel - Re: [PATCH v3] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 9 Feb 2024 09:49:55 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Tor Vic <torvic9@...lbox.org>, Perry.Yuan@....com, ray.huang@....com,
 gautham.shenoy@....com, rafael.j.wysocki@...el.com
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 Oleksandr Natalenko <oleksandr@...alenko.name>
Subject: Re: [PATCH v3] cpufreq: amd-pstate: Fix min_perf assignment in
 amd_pstate_adjust_perf()

On 2/9/2024 09:42, Tor Vic wrote:
> In the function amd_pstate_adjust_perf(), the 'min_perf' variable is set
> to 'highest_perf' instead of 'lowest_perf'.
> 
> Cc: <stable@...r.kernel.org> # 6.1+
> Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")
> Reported-by: Oleksandr Natalenko <oleksandr@...alenko.name>
> Reviewed-by: Perry Yuan <Perry.Yuan@....com>
> Signed-off-by: Tor Vic <torvic9@...lbox.org>
Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> ---
> v2->v3: Resend with git, misconfigured mail client borked v2
> v1->v2: Add Perry's 'Reviewed-by' and 'Cc: stable' tag
> ---
>   drivers/cpufreq/amd-pstate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 08e112444c27..aa5e57e27d2b 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -577,7 +577,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
>   	if (target_perf < capacity)
>   		des_perf = DIV_ROUND_UP(cap_perf * target_perf, capacity);
>   
> -	min_perf = READ_ONCE(cpudata->highest_perf);
> +	min_perf = READ_ONCE(cpudata->lowest_perf);
>   	if (_min_perf < capacity)
>   		min_perf = DIV_ROUND_UP(cap_perf * _min_perf, capacity);
>