[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e660af3f-60ed-4386-b00e-98db61ee84c4@linaro.org>
Date: Fri, 9 Feb 2024 17:59:06 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Marijn Suijten <marijn.suijten@...ainline.org>, g@...ainline.org
Cc: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, ~postmarketos/upstreaming@...ts.sr.ht,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Luca Weiss <luca@...tu.xyz>, Adam Skladowski <a39.skl@...il.com>,
Martin Botka <martin.botka@...ainline.org>,
Jami Kettunen <jami.kettunen@...ainline.org>, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: msm8976: Declare and use SDC1
pins
On 6.02.2024 23:36, Marijn Suijten wrote:
> On 2024-02-06 19:58:50, Konrad Dybcio wrote:
>> On 21.01.2024 23:33, Marijn Suijten wrote:
>>> Add the pinctrl states for SDC1 and use them on sdhc_1.
>>>
>>> Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org>
>>> ---
>>
>> [...]
>>
>>
>>> @@ -840,6 +890,11 @@ sdhc_1: mmc@...4900 {
>>> <&gcc GCC_SDCC1_APPS_CLK>,
>>> <&rpmcc RPM_SMD_XO_CLK_SRC>;
>>> clock-names = "iface", "core", "xo";
>>> +
>>> + pinctrl-names = "default", "sleep";
>>> + pinctrl-0 = <&sdc1_on_state>;
>>> + pinctrl-1 = <&sdc1_off_state>;
>>
>> -names should go last
>
> Per the cover letter:
>
> - Moved pinctrl-names before pinctrl-N (Konrad);
>
> You explicitly requested this in https://lore.kernel.org/linux-arm-msm/60a40ace-d4e9-df74-88f9-4354d80efaac@linaro.org/#t
> but we also backtracked on it somewhat for consistency with other -names, and the general state of this file.
Agreed, but we made up our minds since 2022-12-15 ;)
Konrad
Powered by blists - more mailing lists