linux-kernel - Re: [PATCH 2/2] arm64: dts: ti: k3-j721e-sk: fix PMIC interrupt number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 9 Feb 2024 18:09:41 +0100
From: Romain Naour <romain.naour@...le.fr>
To: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, conor+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org, kristo@...nel.org,
 vigneshr@...com, nm@...com
Cc: Neha Malcom Francis <n-francis@...com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-j721e-sk: fix PMIC interrupt
 number

Hello,

Le 08/02/2024 à 22:24, Romain Naour a écrit :
> The tps659413 node set WKUP_GPIO0_7 (G28) pin as input to be used as
> PMIC interrupt but uses 9 (WKUP_GPIO0_9) as "interrupts" property.
> 
> Replace 9 by 7 after checking in the board schematic [1].
> 
> [1] https://www.ti.com/tool/SK-TDA4VM
> 
> Fixes: b808cef0be46 ("arm64: dts: ti: k3-j721e-sk: Add TPS6594 family PMICs")
> Cc: Neha Malcom Francis <n-francis@...com>
> Signed-off-by: Romain Naour <romain.naour@...le.fr>
> ---
>  arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 188dfe291a32..6a8866055f77 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -574,7 +574,7 @@ tps659413: pmic@48 {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pmic_irq_pins_default>;
>  		interrupt-parent = <&wkup_gpio0>;
> -		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> +		interrupts = <7 IRQ_TYPE_EDGE_FALLING>;

We need to do this change for both tps659413 and tps659411 nodes for the
k3-j721e-sk board.

There is only one PMIC on k3-am69-sk.

I'll send a v2.

Best regards,
Romain


>  		gpio-controller;
>  		#gpio-cells = <2>;
>  		ti,primary-pmic;