linux-kernel - Re: [PATCH] drm/radeon/ni: Fix wrong firmware size logging in ni_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_NoGaKr0HcBfNbjX3E+_8s_H+77OB5ESFgQiHAxsWKBjg@mail.gmail.com>
Date: Fri, 9 Feb 2024 13:09:32 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Nikita Zhandarovich <n.zhandarovich@...tech.ru>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	"Pan, Xinhui" <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] drm/radeon/ni: Fix wrong firmware size logging in ni_init_microcode()

Applied.  Thanks!

On Tue, Feb 6, 2024 at 11:48 AM Nikita Zhandarovich
<n.zhandarovich@...tech.ru> wrote:
>
> Clean up a typo in pr_err() erroneously printing NI MC 'rdev->mc_fw->size'
> during SMC firmware load. Log 'rdev->smc_fw->size' instead.
>
> Found by Linux Verification Center (linuxtesting.org) with static
> analysis tool SVACE.
>
> Fixes: 6596afd48af4 ("drm/radeon/kms: add dpm support for btc (v3)")
> Signed-off-by: Nikita Zhandarovich <n.zhandarovich@...tech.ru>
> ---
>  drivers/gpu/drm/radeon/ni.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c
> index 927e5f42e97d..3e48cbb522a1 100644
> --- a/drivers/gpu/drm/radeon/ni.c
> +++ b/drivers/gpu/drm/radeon/ni.c
> @@ -813,7 +813,7 @@ int ni_init_microcode(struct radeon_device *rdev)
>                         err = 0;
>                 } else if (rdev->smc_fw->size != smc_req_size) {
>                         pr_err("ni_mc: Bogus length %zu in firmware \"%s\"\n",
> -                              rdev->mc_fw->size, fw_name);
> +                              rdev->smc_fw->size, fw_name);
>                         err = -EINVAL;
>                 }
>         }
> --
> 2.25.1
>