linux-kernel - Re: [PATCH v2] siox: make siox_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <gixkaq442day5gcirj5rbcb4pbihlma2ruhrpqweyvzqx5rz3j@hpt5esbvvloj>
Date: Fri, 9 Feb 2024 19:13:54 +0100
From: Thorsten Scherer <T.Scherer@...elmann.de>
To: "Ricardo B. Marliere" <ricardo@...liere.net>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, linux-kernel@...r.kernel.org, 
	Thorsten Scherer <T.Scherer@...elmann.de>
Subject: Re: [PATCH v2] siox: make siox_bus_type const

Hello,

On Sun, Feb 04, 2024 at 07:26:42PM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> a const *"), the driver core can properly handle constant struct
> bus_type. Move the siox_bus_type variable to be a constant structure as
> well, placing it into read-only memory which can not be modified at
> runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@...liere.net>

Acked-by: Thorsten Scherer <t.scherer@...elmann.de>

@Ricardo: Thank you!

@gregkh: Would you please pick up this patch?

> ---
> Changes in v2:
> - Fixed changelog: mentioned commit d492cc2573a0 instead of the word
>   "Now".
> - Link to v1: https://lore.kernel.org/r/20240204-bus_cleanup-siox-v1-1-2d12583d3a6c@marliere.net
> ---
>  drivers/siox/siox-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
> index 561408583b2b..a1eda7bd76ed 100644
> --- a/drivers/siox/siox-core.c
> +++ b/drivers/siox/siox-core.c
> @@ -543,7 +543,7 @@ static void siox_shutdown(struct device *dev)
>  		sdriver->shutdown(sdevice);
>  }
>  
> -static struct bus_type siox_bus_type = {
> +static const struct bus_type siox_bus_type = {
>  	.name = "siox",
>  	.match = siox_match,
>  	.probe = siox_probe,
> 
> ---
> base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
> change-id: 20240204-bus_cleanup-siox-ccf8775bf069
> 
> Best regards,
> -- 
> Ricardo B. Marliere <ricardo@...liere.net>
> 

Best regards
Thorsten