linux-kernel - Re: [PATCH v2 1/5] sched/vtime: remove confusing arch_vtime_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CZ089ERGIDWI.14PQB4HD4F1NH@wheely>
Date: Fri, 09 Feb 2024 13:28:17 +1000
From: "Nicholas Piggin" <npiggin@...il.com>
To: "Alexander Gordeev" <agordeev@...ux.ibm.com>, "Frederic Weisbecker"
 <frederic@...nel.org>, "Ingo Molnar" <mingo@...nel.org>, "Michael Ellerman"
 <mpe@...erman.id.au>, "Heiko Carstens" <hca@...ux.ibm.com>, "Vasily Gorbik"
 <gor@...ux.ibm.com>
Cc: <linux-kernel@...r.kernel.org>, <linux-s390@...r.kernel.org>,
 <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH v2 1/5] sched/vtime: remove confusing
 arch_vtime_task_switch() declaration

On Fri Feb 9, 2024 at 6:15 AM AEST, Alexander Gordeev wrote:
> Callback arch_vtime_task_switch() is only defined when
> CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is selected. Yet, the
> function prototype forward declaration is present for
> CONFIG_VIRT_CPU_ACCOUNTING_GEN variant. Remove it.
>

And powerpc arch_vtime_task_switch is static inline too,
so this just confuses things.

Reviewed-by: Nicholas Piggin <npiggin@...il.com>

> Reviewed-by: Frederic Weisbecker <frederic@...nel.org>
> Signed-off-by: Alexander Gordeev <agordeev@...ux.ibm.com>
> ---
>  include/linux/vtime.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/vtime.h b/include/linux/vtime.h
> index 3684487d01e1..593466ceebed 100644
> --- a/include/linux/vtime.h
> +++ b/include/linux/vtime.h
> @@ -18,7 +18,6 @@ extern void vtime_account_idle(struct task_struct *tsk);
>  #endif /* !CONFIG_VIRT_CPU_ACCOUNTING */
>  
>  #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN
> -extern void arch_vtime_task_switch(struct task_struct *tsk);
>  extern void vtime_user_enter(struct task_struct *tsk);
>  extern void vtime_user_exit(struct task_struct *tsk);
>  extern void vtime_guest_enter(struct task_struct *tsk);