linux-kernel - Re: [PATCH] fbdev/sh7760fb: allow modular build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 10 Feb 2024 10:31:32 +0100
From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, Thomas Zimmermann
 <tzimmermann@...e.de>, Javier Martinez Canillas <javierm@...hat.com>, Sam
 Ravnborg <sam@...nborg.org>, Helge Deller <deller@....de>,
 linux-fbdev@...r.kernel.org,  dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] fbdev/sh7760fb: allow modular build

On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote:
> There is no reason to prohibit sh7760fb from being built as a
> loadable module as suggested by Geert, so change the config symbol
> from bool to tristate to allow that and change the FB dependency as
> needed.
> 
> Fixes: f75f71b2c418 ("fbdev/sh7760fb: Depend on FB=y")
> Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Javier Martinez Canillas <javierm@...hat.com>
> Cc: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: Helge Deller <deller@....de>
> Cc: linux-fbdev@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> ---
>  drivers/video/fbdev/Kconfig |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1645,8 +1645,8 @@ config FB_COBALT
>  	select FB_IOMEM_HELPERS
>  
>  config FB_SH7760
> -	bool "SH7760/SH7763/SH7720/SH7721 LCDC support"
> -	depends on FB=y && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
> +	tristate "SH7760/SH7763/SH7720/SH7721 LCDC support"
> +	depends on FB && (CPU_SUBTYPE_SH7760 || CPU_SUBTYPE_SH7763 \
>  		|| CPU_SUBTYPE_SH7720 || CPU_SUBTYPE_SH7721)
>  	select FB_IOMEM_HELPERS
>  	help

Acked-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913