[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJprROcMa5U0Q8fMk_aJpk6ecMoDKhtD31CCss-bHu2S+7Q@mail.gmail.com>
Date: Sat, 10 Feb 2024 13:53:16 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
patches@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
Douglas Anderson <dianders@...omium.org>, Pin-yen Lin <treapking@...omium.org>,
cros-qcom-dts-watchers@...omium.org, Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH 21/22] arm64: dts: qcom: sc7180-trogdor: Make
clamshell/detachable fragments
On Sat, 10 Feb 2024 at 09:17, Stephen Boyd <swboyd@...omium.org> wrote:
>
> At a high-level, detachable Trogdors (sometimes known as Strongbads)
> don't have a cros_ec keyboard, while all clamshell Trogdors (only known
> as Trogdors) always have a cros_ec keyboard. Looking closer though, all
> clamshells have a USB type-A connector and a hardwired USB camera. And
> all detachables replace the USB camera with a MIPI based one and swap
> the USB type-a connector for the detachable keyboard pogo pins.
>
> Split the detachable and clamshell bits into different files so we can
> describe these differences in one place instead of in each board that
> includes sc7180-trogdor.dtsi. For now this is just the keyboard part,
> but eventually this will include the type-a port and the pogo pins.
>
> Cc: <cros-qcom-dts-watchers@...omium.org>
> Cc: Andy Gross <agross@...nel.org>
> Cc: Bjorn Andersson <andersson@...nel.org>
> Cc: Konrad Dybcio <konrad.dybcio@...aro.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> Cc: Conor Dooley <conor+dt@...nel.org>
> Cc: <linux-arm-msm@...r.kernel.org>
> Cc: <devicetree@...r.kernel.org>
> Cc: Pin-yen Lin <treapking@...omium.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
> .../boot/dts/qcom/sc7180-trogdor-clamshell.dtsi | 9 +++++++++
> arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 5 +----
> .../boot/dts/qcom/sc7180-trogdor-detachable.dtsi | 12 ++++++++++++
> .../arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi | 7 +------
> .../boot/dts/qcom/sc7180-trogdor-kingoftown.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 3 +--
> arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 2 +-
> .../boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi | 7 +------
> arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 2 +-
> .../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi | 5 +----
> 11 files changed, 30 insertions(+), 26 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
--
With best wishes
Dmitry
Powered by blists - more mailing lists