linux-kernel - Re: [PATCH v2 02/35] include: remove unnecessary #include directives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 10 Feb 2024 20:58:40 +0800
From: kernel test robot <lkp@...el.com>
To: Max Kellermann <max.kellermann@...os.com>, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Max Kellermann <max.kellermann@...os.com>
Subject: Re: [PATCH v2 02/35] include: remove unnecessary #include directives

Hi Max,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20240209]
[cannot apply to drm-misc/drm-misc-next media-tree/master mkp-scsi/for-next linus/master v6.8-rc3 v6.8-rc2 v6.8-rc1 v6.8-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Max-Kellermann/include-add-missing-includes/20240210-005417
base:   next-20240209
patch link:    https://lore.kernel.org/r/20240209164027.2582906-3-max.kellermann%40ionos.com
patch subject: [PATCH v2 02/35] include: remove unnecessary #include directives
config: i386-buildonly-randconfig-006-20240210 (https://download.01.org/0day-ci/archive/20240210/202402102047.IswSP6zZ-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240210/202402102047.IswSP6zZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402102047.IswSP6zZ-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/sun4i/sun4i_layer.c:28:3: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      28 |                 kfree(state);
         |                 ^
   drivers/gpu/drm/sun4i/sun4i_layer.c:28:3: note: did you mean 'vfree'?
   include/linux/vmalloc.h:160:13: note: 'vfree' declared here
     160 | extern void vfree(const void *addr);
         |             ^
>> drivers/gpu/drm/sun4i/sun4i_layer.c:32:10: error: call to undeclared function 'kzalloc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      32 |         state = kzalloc(sizeof(*state), GFP_KERNEL);
         |                 ^
   drivers/gpu/drm/sun4i/sun4i_layer.c:32:10: note: did you mean 'vzalloc'?
   include/linux/vmalloc.h:140:14: note: 'vzalloc' declared here
     140 | extern void *vzalloc(unsigned long size) __alloc_size(1);
         |              ^
>> drivers/gpu/drm/sun4i/sun4i_layer.c:32:8: error: incompatible integer to pointer conversion assigning to 'struct sun4i_layer_state *' from 'int' [-Wint-conversion]
      32 |         state = kzalloc(sizeof(*state), GFP_KERNEL);
         |               ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/sun4i/sun4i_layer.c:43:9: error: call to undeclared function 'kzalloc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      43 |         copy = kzalloc(sizeof(*copy), GFP_KERNEL);
         |                ^
   drivers/gpu/drm/sun4i/sun4i_layer.c:43:7: error: incompatible integer to pointer conversion assigning to 'struct sun4i_layer_state *' from 'int' [-Wint-conversion]
      43 |         copy = kzalloc(sizeof(*copy), GFP_KERNEL);
         |              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/sun4i/sun4i_layer.c:60:2: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      60 |         kfree(s_state);
         |         ^
   6 errors generated.


vim +/kfree +28 drivers/gpu/drm/sun4i/sun4i_layer.c

9026e0d122ac87 Maxime Ripard      2015-10-29  18  
d540f82adf3577 Maxime Ripard      2018-01-22  19  static void sun4i_backend_layer_reset(struct drm_plane *plane)
d540f82adf3577 Maxime Ripard      2018-01-22  20  {
d540f82adf3577 Maxime Ripard      2018-01-22  21  	struct sun4i_layer_state *state;
d540f82adf3577 Maxime Ripard      2018-01-22  22  
d540f82adf3577 Maxime Ripard      2018-01-22  23  	if (plane->state) {
d540f82adf3577 Maxime Ripard      2018-01-22  24  		state = state_to_sun4i_layer_state(plane->state);
d540f82adf3577 Maxime Ripard      2018-01-22  25  
d540f82adf3577 Maxime Ripard      2018-01-22  26  		__drm_atomic_helper_plane_destroy_state(&state->state);
d540f82adf3577 Maxime Ripard      2018-01-22  27  
d540f82adf3577 Maxime Ripard      2018-01-22 @28  		kfree(state);
d540f82adf3577 Maxime Ripard      2018-01-22  29  		plane->state = NULL;
d540f82adf3577 Maxime Ripard      2018-01-22  30  	}
d540f82adf3577 Maxime Ripard      2018-01-22  31  
d540f82adf3577 Maxime Ripard      2018-01-22 @32  	state = kzalloc(sizeof(*state), GFP_KERNEL);
e4fff65fdb526a Maxime Ripard      2022-02-21  33  	if (state)
60252323ec9c36 Alexandru Gheorghe 2018-08-04  34  		__drm_atomic_helper_plane_reset(plane, &state->state);
d540f82adf3577 Maxime Ripard      2018-01-22  35  }
d540f82adf3577 Maxime Ripard      2018-01-22  36  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki