linux-kernel - Re: [PATCH] ntfs3: avoid an unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a47e652b-120f-4147-9163-cdef251616d1@roeck-us.net>
Date: Sat, 10 Feb 2024 07:29:23 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
	Arnd Bergmann <arnd@...db.de>,
	Christian Brauner <brauner@...nel.org>,
	Jeff Layton <jlayton@...nel.org>,
	Jia-Ju Bai <baijiaju1990@...il.com>,
	Edward Lo <loyuantsung@...il.com>,
	Abdun Nihaal <abdun.nihaal@...il.com>, ntfs3@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ntfs3: avoid an unused variable warning

On Fri, Feb 02, 2024 at 01:50:56PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A newly introduced variable is only referenced in an #ifdef:
> 
> fs/ntfs3/frecord.c: In function 'ni_read_frame':
> fs/ntfs3/frecord.c:2460:16: error: unused variable 'i_size' [-Werror=unused-variable]
> 
> Move it into the same conditional block.
> 
> Fixes: 4fd6c08a16d7 ("fs/ntfs3: Use i_size_read and i_size_write")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Tested-by: Guenter Roeck <linux@...ck-us.net>