linux-kernel - Re: [PATCH v3 1/3] iio: humidity: hdc3020: drop u8 register pairs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240210175521.6984cee6@jic23-huawei>
Date: Sat, 10 Feb 2024 17:55:21 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Dimitri Fedrau <dima.fedrau@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Javier Carrasco
 <javier.carrasco.cruz@...il.com>, Li peiyu <579lpy@...il.com>, Nuno Sa
 <nuno.sa@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] iio: humidity: hdc3020: drop u8 register pairs

On Wed,  7 Feb 2024 08:47:51 +0100
Dimitri Fedrau <dima.fedrau@...il.com> wrote:

> Switch to 16bit defines. Create helper functions that are aware of the
> new register format and apply them wherever possible.

The dropping of const is an unrelated (though sensible) change.
Given it's really minor, just calling it out with a comment here would be
fine (rather than a separate patch).

Otherwise looks good to me.  Thanks for cleaning this up.

Jonathan

> 
> Signed-off-by: Dimitri Fedrau <dima.fedrau@...il.com>