linux-kernel - Re: [PATCH v1 04/14] dt-bindings: input: touchscreen: fsl,imx6ul-tsc convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c2d8bee-e9c6-45db-a166-d344f7890e06@linaro.org>
Date: Sun, 11 Feb 2024 13:46:26 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 NXP Linux Team <linux-imx@....com>
Cc: Dong Aisheng <aisheng.dong@....com>,
 Linus Walleij <linus.walleij@...aro.org>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Mark Brown
 <broonie@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 04/14] dt-bindings: input: touchscreen: fsl,imx6ul-tsc
 convert to YAML

On 10/02/2024 02:18, Sebastian Reichel wrote:
> Convert the i.MX6UL touchscreen DT binding to YAML.
> 
> Signed-off-by: Sebastian Reichel <sre@...nel.org>
> ---

..

> +
> +  interrupts:
> +    items:
> +      - description: touch controller address
> +      - description: ADC2 address
> +
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: tsc
> +      - const: adc
> +
> +  xnur-gpio:

xnur-gpios:

Also you need:
maxItems: 1

> +    description:
> +      The X- gpio this controller connect to. This xnur-gpio returns to
> +      low once the finger leave the touch screen (The last touch event
> +      the touch controller capture).
> +
> +  measure-delay-time:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      The value of measure delay time. Before X-axis or Y-axis measurement,
> +      the screen need some time before even potential distribution ready.
> +    default: 0xffff
> +    minimum: 0
> +    maximum: 0xffffff

Time seems like something humans can grasp, so why using hexadecimal
numbers? Same question for pre-charge-time.


> +
> +  pre-charge-time:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      The touch screen need some time to precharge.
> +    default: 0xfff
> +    minimum: 0
> +    maximum: 0xffffffff
> +
> +  touchscreen-average-samples:
> +    description: Number of data samples which are averaged for each read.

This should fail the testing - judging by Rob's reports, you did not
test it. You don't have type for this property. Missing allOf: to
touchscreen.

> +    enum: [ 1, 4, 8, 16, 32 ]
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - xnur-gpio
> +


allOf: with $ref to touchscreen.

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/clock/imx6ul-clock.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +    tsc: tsc@...0000 {

Drop label and just "touchscreen@...0000"


Best regards,
Krzysztof