linux-kernel - Re: [PATCH v4 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e231871-0e49-446f-8a3b-d66e5cf6838b@suse.de>
Date: Sun, 11 Feb 2024 22:52:27 +0900
From: Hannes Reinecke <hare@...e.de>
To: Lee Duncan <leeman.duncan@...il.com>, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Chengfeng Ye <dg573847474@...il.com>, Satish Kharat <satishkh@...co.com>,
 Sesidhar Baddela <sebaddel@...co.com>, Karan Tilak Kumar
 <kartilak@...co.com>, Lee Duncan <lduncan@...e.com>
Subject: Re: [PATCH v4 1/2] Revert "scsi: fcoe: Fix potential deadlock on
 &fip->ctlr_lock"

On 2/10/24 02:07, Lee Duncan wrote:
> From: Lee Duncan <lduncan@...e.com>
> 
> This reverts commit 1a1975551943f681772720f639ff42fbaa746212
> 
> This commit causes interrupts to be lost for FCoE devices,
> since it changed sping locks from "bh" to "irqsave".
> 
> Instead, a work queue should be used, and will be addressed
> in a separate patch.
> 
> Fixes: 1a1975551943 ("scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock")
> Signed-off-by: Lee Duncan <lduncan@...e.com>
> ---
>   drivers/scsi/fcoe/fcoe_ctlr.c | 20 ++++++++------------
>   1 file changed, 8 insertions(+), 12 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@...e.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich