[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240211150516.3475-1-d.dulov@aladdin.ru>
Date: Sun, 11 Feb 2024 07:05:16 -0800
From: Daniil Dulov <d.dulov@...ddin.ru>
To: Kalle Valo <kvalo@...eaurora.org>
CC: Daniil Dulov <d.dulov@...ddin.ru>, "David S. Miller"
<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Pieter-Paul
Giesberts <pieterpg@...adcom.com>, "Franky (Zhenhui) Lin"
<frankyl@...adcom.com>, "John W. Linville" <linville@...driver.com>, Kan Yan
<kanyan@...adcom.com>, <linux-wireless@...r.kernel.org>,
<brcm80211-dev-list.pdl@...adcom.com>, <SHA-cyfmac-dev-list@...ineon.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<lvc-project@...uxtesting.org>
Subject: [PATCH] brcmfmac: Remove unnecessary NULL-check.
In this case req will never be NULL, so remove unnecessary check.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 71bb244ba2fd ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets")
Signed-off-by: Daniil Dulov <d.dulov@...ddin.ru>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
index 9fb68c2dc7e3..38e4e4f32a39 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
@@ -455,8 +455,7 @@ brcmf_usbdev_qinit(struct list_head *q, int qsize)
brcmf_err("fail!\n");
while (!list_empty(q)) {
req = list_entry(q->next, struct brcmf_usbreq, list);
- if (req)
- usb_free_urb(req->urb);
+ usb_free_urb(req->urb);
list_del(q->next);
}
kfree(reqs);
--
2.25.1
Powered by blists - more mailing lists