lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <735172b1-1267-43e7-a2af-8596d849760a@auristor.com>
Date: Sun, 11 Feb 2024 12:24:09 -0500
From: Jeffrey E Altman <jaltman@...istor.com>
To: Daniil Dulov <d.dulov@...ddin.ru>, linux-afs@...ts.infradead.org
Cc: Marc Dionne <marc.dionne@...istor.com>,
 David Howells <dhowells@...hat.com>, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH] afs: Increase buffer size in afs_update_volume_status()

On 2/11/2024 10:04 AM, Daniil Dulov wrote:
> The max length of volume->vid value is 20 characters.
> So increase idbuf[] size up to 20 to avoid overflow.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
> Signed-off-by: Daniil Dulov <d.dulov@...ddin.ru>
> ---
>   fs/afs/volume.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/afs/volume.c b/fs/afs/volume.c
> index f84194b791d3..9d0da38bbcf6 100644
> --- a/fs/afs/volume.c
> +++ b/fs/afs/volume.c
> @@ -302,7 +302,7 @@ static int afs_update_volume_status(struct afs_volume *volume, struct key *key)
>   {
>   	struct afs_server_list *new, *old, *discard;
>   	struct afs_vldb_entry *vldb;
> -	char idbuf[16];
> +	char idbuf[19];
>   	int ret, idsz;
>   
>   	_enter("");

Thanks for the patch.

The commit message says idbuf[] is being increased to 20 chars but the 
patch only increases it to 19.

Should idbuf[] be 20 or should the commit message be altered?

Jeffrey Altman



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ