linux-kernel - Re: [PATCHv6 1/2] watchdog/softlockup: low-overhead detection of interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 11 Feb 2024 15:46:35 -0800
From: Doug Anderson <dianders@...omium.org>
To: Petr Mladek <pmladek@...e.com>
Cc: Bitao Hu <yaoma@...ux.alibaba.com>, akpm@...ux-foundation.org, 
	kernelfans@...il.com, liusong@...ux.alibaba.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv6 1/2] watchdog/softlockup: low-overhead detection of interrupt

Hi,

On Fri, Feb 9, 2024 at 5:35 AM Petr Mladek <pmladek@...e.com> wrote:
>
> Hi,
>
> I am sorry for jouning this game so late. But honestly, it went
> forward too quickly. A good practice is to wait a week before
> sending new version so that you give a chance more people
> to provide some feedback.
>
> The only exception might be when you know exactly who could
> review it because the area in not interesting for anyone else.
> But this is typicall not the case for kernel core code.

Just for the record, I am not personally a fan of the advice that you
need to unconditionally wait a week between spins.

FWIW, I _am_ totally sold on the idea of waiting a while if there is
still ongoing discussion about how to move forward. You don't want to
fragment the conversation with some replies against the old version
and some against the new. However, in this case there was no ongoing
discussion and I don't see any particular harm that was done with
Bitao spinning as often as he did. I actually find it quite nice not
to need to wait a week (or more) between versions because it means
that patches are still fresh in my mind when I review the next
version.

Is your concern that some of my advice to Bitao took the series in the
wrong direction and you wished you could have put a stop to it sooner?
..or is your concern that Andrew has already landed the current
patches in his "unstable" tree? ...or is there some other problem that
was caused by Biao's quick spins of this series?

In any case, I'm happy that you've found time to jump in and review
the code! My current understanding of Andrew's process is that since
things are only in his "unstable" branch that Bitao can still send new
versions of the series and Andrew can update the patches.

-Doug