linux-kernel - Re: [PATCH v7 4/4] vfio: convey kvm that the vfio-pci device is wc safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 12 Feb 2024 10:05:02 -0700
From: Alex Williamson <alex.williamson@...hat.com>
To: <ankita@...dia.com>
Cc: <jgg@...dia.com>, <maz@...nel.org>, <oliver.upton@...ux.dev>,
 <james.morse@....com>, <suzuki.poulose@....com>, <yuzenghui@...wei.com>,
 <reinette.chatre@...el.com>, <surenb@...gle.com>, <stefanha@...hat.com>,
 <brauner@...nel.org>, <catalin.marinas@....com>, <will@...nel.org>,
 <mark.rutland@....com>, <kevin.tian@...el.com>, <yi.l.liu@...el.com>,
 <ardb@...nel.org>, <akpm@...ux-foundation.org>, <andreyknvl@...il.com>,
 <wangjinchao@...sion.com>, <gshan@...hat.com>, <shahuang@...hat.com>,
 <ricarkol@...gle.com>, <linux-mm@...ck.org>, <lpieralisi@...nel.org>,
 <rananta@...gle.com>, <ryan.roberts@....com>, <david@...hat.com>,
 <linus.walleij@...aro.org>, <bhe@...hat.com>, <aniketa@...dia.com>,
 <cjia@...dia.com>, <kwankhede@...dia.com>, <targupta@...dia.com>,
 <vsethi@...dia.com>, <acurrid@...dia.com>, <apopple@...dia.com>,
 <jhubbard@...dia.com>, <danw@...dia.com>, <kvmarm@...ts.linux.dev>,
 <mochs@...dia.com>, <zhiw@...dia.com>, <kvm@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v7 4/4] vfio: convey kvm that the vfio-pci device is wc
 safe

On Sun, 11 Feb 2024 23:17:05 +0530
<ankita@...dia.com> wrote:

> From: Ankit Agrawal <ankita@...dia.com>
> 
> The code to map the MMIO in S2 as NormalNC is enabled when conveyed
> that the device is WC safe using a new flag VM_ALLOW_ANY_UNCACHED.
> 
> Make vfio-pci set the VM_ALLOW_ANY_UNCACHED flag.
> 
> This could be extended to other devices in the future once that
> is deemed safe.
> 
> Suggested-by: Catalin Marinas <catalin.marinas@....com>
> Acked-by: Jason Gunthorpe <jgg@...dia.com>
> Acked-by: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Ankit Agrawal <ankita@...dia.com>
> ---
>  drivers/vfio/pci/vfio_pci_core.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
> index 1cbc990d42e0..eba2146202f9 100644
> --- a/drivers/vfio/pci/vfio_pci_core.c
> +++ b/drivers/vfio/pci/vfio_pci_core.c
> @@ -1862,8 +1862,12 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma
>  	/*
>  	 * See remap_pfn_range(), called from vfio_pci_fault() but we can't
>  	 * change vm_flags within the fault handler.  Set them now.
> +	 *
> +	 * Set an additional flag VM_ALLOW_ANY_UNCACHED to convey kvm that
> +	 * the device is wc safe.
>  	 */

That's a pretty superficial comment.  Check that this is accurate, but
maybe something like:

	The VM_ALLOW_ANY_UNCACHED flag is implemented for ARM64,
	allowing stage 2 device mapping attributes to use Normal-NC
	rather than DEVICE_nGnRE, which allows guest mappings
	supporting combining attributes (WC).  This attribute has
	potential risks with the GICv2 VCPU interface, but is expected
	to be safe for vfio-pci use cases.

And specifically, I think these other devices that may be problematic
as described in the cover letter is a warning against use for
vfio-platform, is that correct?

Thanks,
Alex

> -	vm_flags_set(vma, VM_IO | VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP);
> +	vm_flags_set(vma, VM_ALLOW_ANY_UNCACHED | VM_IO | VM_PFNMAP |
> +			VM_DONTEXPAND | VM_DONTDUMP);
>  	vma->vm_ops = &vfio_pci_mmap_ops;
>  
>  	return 0;