linux-kernel - Re: [PATCH v15-RFC 6/8] x86/resctrl: Introduce snc_nodes_per_l3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5eb8850b-ada0-4945-b81a-995fd0b8b134@amd.com>
Date: Mon, 12 Feb 2024 11:22:56 -0600
From: "Moger, Babu" <babu.moger@....com>
To: Tony Luck <tony.luck@...el.com>
Cc: Fenghua Yu <fenghua.yu@...el.com>,
 Reinette Chatre <reinette.chatre@...el.com>,
 Peter Newman <peternewman@...gle.com>, Jonathan Corbet <corbet@....net>,
 Shuah Khan <skhan@...uxfoundation.org>, x86@...nel.org,
 Shaopeng Tan <tan.shaopeng@...itsu.com>, James Morse <james.morse@....com>,
 Jamie Iles <quic_jiles@...cinc.com>, Randy Dunlap <rdunlap@...radead.org>,
 Drew Fustini <dfustini@...libre.com>, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH v15-RFC 6/8] x86/resctrl: Introduce snc_nodes_per_l3_cache

Hi Tony,

On 2/9/24 13:35, Tony Luck wrote:
> On Fri, Feb 09, 2024 at 09:29:16AM -0600, Moger, Babu wrote:
>>>  
>>> +extern unsigned int snc_nodes_per_l3_cache;
>>
>> I feel this can be part of rdt_resource instead of global.
> 
> Mixed emotions about that. It would be another field that appears
> in every instance of rdt_resource, but only used by the RDT_RESOURCE_L3_MON
> copy.
> 
That was the comment I got earlier for my patches(search for global).

https://lore.kernel.org/lkml/47f870e0-ad1a-4a4d-9d9e-4c05bf431858@intel.com/
-- 
Thanks
Babu Moger