[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240212-stowaway-cartel-3aee8992cbd3@spud>
Date: Mon, 12 Feb 2024 17:34:16 +0000
From: Conor Dooley <conor@...nel.org>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
Andre Przywara <andre.przywara@....com>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: sunxi: Add Sipeed Longan Module
3H and Longan Pi 3H
On Mon, Feb 12, 2024 at 06:34:36PM +0800, Jisheng Zhang wrote:
> On Sun, Feb 11, 2024 at 05:29:32PM +0100, Krzysztof Kozlowski wrote:
> > On 11/02/2024 09:17, Jisheng Zhang wrote:
> > > Add name & compatible for the Sipeed Longan Module 3H and Longan PI 3H
> > > board.
> > >
> > > Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> > > Reviewed-by: Andre Przywara <andre.przywara@....com>
> > > ---
> >
> > This is a friendly reminder during the review process.
>
> Oops, I forgot to add Conor's ack...
> >
> > It looks like you received a tag and forgot to add it.
> >
> > If you do not know the process, here is a short explanation:
> > Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> > versions, under or above your Signed-off-by tag. Tag is "received", when
> > provided in a message replied to you on the mailing list. Tools like b4
> > can help here. However, there's no need to repost patches *only* to add
> > the tags. The upstream maintainer will do that for tags received on the
> > version they apply.
>
> IIRC, the b4 can only help on the latest version. If I missed the ack
> in v3, the ack tag will be lost. So how to handle this case? repost or
> Conor gave an ack to v3 again?
I think what the form letter means is that b4 could've been used to
update the tags before you sent out this version.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Thanks,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists