linux-kernel - Re: [PATCH v2] soc: qcom: llcc: Check return value on Broadcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <989fa518-4f02-4725-97a4-2f711126939d@quicinc.com>
Date: Mon, 12 Feb 2024 09:47:09 -0800
From: Unnathi Chalicheemala <quic_uchalich@...cinc.com>
To: Jeff Johnson <quic_jjohnson@...cinc.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Abel Vesa
	<abel.vesa@...aro.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...cinc.com>, Elliot Berman <quic_eberman@...cinc.com>
Subject: Re: [PATCH v2] soc: qcom: llcc: Check return value on Broadcast_OR
 reg read

On 2/9/2024 5:30 PM, Jeff Johnson wrote:
> On 2/9/2024 5:14 PM, Unnathi Chalicheemala wrote:
>> Commit c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
>> introduced a new 4.1 if statement in llcc_update_act_ctrl() without
>> considering that ret might be overwritten. So, adding return value check
> 
> nit: s/adding/add/ (use imperative voice)
> 

Ack.

>> after Broadcast_OR register read in llcc_update_act_ctrl().
>>
>> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support">
> 
> remove this blank line -- the Fixes tag should be grouped with the other
> tags
> 

Ack. I'll post v3 with these changes, thanks Jeff.

>> Signed-off-by: Unnathi Chalicheemala <quic_uchalich@...cinc.com>
>> Reviewed-by: Elliot Berman <quic_eberman@...cinc.com>