linux-kernel - Re: [PATCH] leds: qcom-lpg: add QCOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 12 Feb 2024 21:06:46 +0100
From: Jean Delvare <jdelvare@...e.de>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, Anjelique
 Melendez <quic_amelende@...cinc.com>, Arnd Bergmann <arnd@...db.de>,
 linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: qcom-lpg: add QCOM_PBS dependency

On Mon, 12 Feb 2024 12:15:02 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The lpg driver fails to link now when the pbs driver is in a loadable module:
> 
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_brightness_set':
> leds-qcom-lpg.c:(.text+0xe7f): undefined reference to `qcom_pbs_trigger_event'
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_probe':
> leds-qcom-lpg.c:(.text+0x16a5): undefined reference to `get_pbs_client_device'
> 
> Add a dependency to avoid the broken configuration. Apparently there is still
> a use for lpg with pbs disabled entirely for certain chips, so allow both
> but not LEDS_QCOM_LPG=y with QCOM_PBS=m.
> 
> Fixes: 214110175679 ("leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/leds/rgb/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index e66bd21b9852..eaeafdd5eaae 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -41,6 +41,7 @@ config LEDS_QCOM_LPG
>  	tristate "LED support for Qualcomm LPG"
>  	depends on OF
>  	depends on PWM
> +	depends on QCOM_PBS || !QCOM_PBS
>  	depends on SPMI
>  	help
>  	  This option enables support for the Light Pulse Generator found in a

Reviewed-by: Jean Delvare <jdelvare@...e.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support