linux-kernel - Re: [PATCHv3] PPPoL2TP: Add more code snippets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcqOvDgXsG2W8t8l@katalix.com>
Date: Mon, 12 Feb 2024 21:33:48 +0000
From: Tom Parkin <tparkin@...alix.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: James Chapman <jchapman@...alix.com>,
	Samuel Thibault <samuel.thibault@...-lyon.org>, edumazet@...gle.com,
	gnault@...hat.com, davem@...emloft.net, pabeni@...hat.com,
	corbet@....net, netdev@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3] PPPoL2TP: Add more code snippets

On  Fri, Feb 09, 2024 at 08:20:46 -0800, Jakub Kicinski wrote:
> On Sat, 3 Feb 2024 23:35:13 +0100 Samuel Thibault wrote:
> > The existing documentation was not telling that one has to create a PPP
> > channel and a PPP interface to get PPPoL2TP data offloading working.
> > 
> > Also, tunnel switching was not mentioned, so that people were thinking
> > it was not supported, while it actually is.
> > 
> > Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>
> 
> James, Tom, looks good?

Sorry for the silence -- I think for v2 we had some discussion of
whether the PPPIOCBRIDGECHAN docs really belonged in l2tp.rst or not
and I wasn't sure whether the same issue would be raised again.

For me I'm happy enough having it mentioned in the l2tp documentation,
so long as the example is clear and accurate.  I've responded to the
patch now with a couple of suggestions on that front.

Thanks,
Tom
-- 
Tom Parkin
Katalix Systems Ltd
https://katalix.com
Catalysts for your Embedded Linux software development

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)