linux-kernel - Re: [PATCH v1 07/14] dt-bindings: lcdif: Do not require power-domains for i.MX6ULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <khwsxrpj5fgxl7ukiur2tdyy7a6d6h6zryc5z2h7o6f7k3b32p@cjqsmdbocfpe>
Date: Tue, 13 Feb 2024 00:10:55 +0100
From: Sebastian Reichel <sre@...nel.org>
To: Stefan Wahren <wahrenst@....net>
Cc: Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Fabio Estevam <festevam@...il.com>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	NXP Linux Team <linux-imx@....com>, Dong Aisheng <aisheng.dong@....com>, 
	Linus Walleij <linus.walleij@...aro.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	Mark Brown <broonie@...nel.org>, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 07/14] dt-bindings: lcdif: Do not require
 power-domains for i.MX6ULL

Hi Stefan,

On Mon, Feb 12, 2024 at 08:20:35PM +0100, Stefan Wahren wrote:
> Am 10.02.24 um 02:18 schrieb Sebastian Reichel:
> > i.MX6UL(L) uses "fsl,imx6sx-lcdif" as fallback compatible string,
> > but has only very lightweight DISPLAY power domain. Its DISPLAY
> > power domain is not supported by the binding / Linux kernel at
> > the moment. Since the current setup is working, let's remove the
> > power-domain from being required for that platform to fix the warning
> > printed by CHECK_DTBS=y.
> i'm not sure this is a good idea. In case i.MX6UL(L) is different from
> i.MX6SX here, then it should have a different compatible.

It already has. The i.MX6UL(L) compatible looks like this:

compatible = "fsl,imx6ul-lcdif", "fsl,imx6sx-lcdif"

So the i.MX6SX one is just a fallback compatible. But the current
requirement for power-domains affects i.MX6UL(L), since it says
the compatible only needs to contain "fsl,imx6sx-lcdif" somewhere
to make power-domains mandatory.

Note, that the kernel driver does not use "fsl,imx6ul-lcdif", so
the hardware itself is indeed compatible.

-- Sebastian