linux-kernel - Re: [PATCH] riscv/fence: Consolidate fence definitions and define _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240212-projector-dangle-7815fa2f7415@wendy>
Date: Mon, 12 Feb 2024 08:03:44 +0000
From: Conor Dooley <conor.dooley@...rochip.com>
To: Eric Chan <ericchancf@...gle.com>
CC: <paul.walmsley@...ive.com>, <palmer@...belt.com>, <aou@...s.berkeley.edu>,
	<linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] riscv/fence: Consolidate fence definitions and define
 __{mb,rmb,wmb}

On Fri, Feb 09, 2024 at 12:50:48PM +0000, Eric Chan wrote:
> Disparate fence implementations are consolidated into fence.h.
> 
> Introduce __{mb,rmb,wmb}, and rely on the generic definitions
> for {mb,rmb,wmb}. A first consequence is that __{mb,rmb,wmb}
> map to a compiler barrier on !SMP (while their definition remains
> unchanged on SMP).
> 
> Introduce RISCV_FULL_BARRIER and use in arch_atomic* function.
> like RISCV_ACQUIRE_BARRIER and RISCV_RELEASE_BARRIER, The fence
> instruction can be eliminated When SMP is not in use.
> 
> Also clean up the warning with scripts/checkpatch.pl.
> 
> Signed-off-by: Eric Chan <ericchancf@...gle.com>

In all configs:
../arch/riscv/include/asm/fence.h:7:10: error: expected expression before '__asm__'
https://patchwork.kernel.org/project/linux-riscv/patch/20240209125048.4078639-1-ericchancf@google.com/

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)