linux-kernel - Re: [PATCH] clk: constify the of_phandle_args argument of of_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZcnsqaIftZXcNaUA@ediswmail9.ad.cirrus.com>
Date: Mon, 12 Feb 2024 10:02:17 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC: Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd
	<sboyd@...nel.org>, Sudeep Holla <sudeep.holla@....com>,
        Peng Fan
	<peng.fan@....com>, Shawn Guo <shawnguo@...nel.org>,
        Nishanth Menon
	<nm@...com>, Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konrad.dybcio@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter
	<jonathanh@...dia.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "Laurent
 Pinchart" <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>,
        Vinod Koul <vkoul@...nel.org>, Russell King
	<linux@...linux.org.uk>,
        Srinivas Kandagatla
	<srinivas.kandagatla@...aro.org>,
        Mark Brown <broonie@...nel.org>, "Jaroslav
 Kysela" <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <linux-clk@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <patches@...nsource.cirrus.com>,
        <linux-stm32@...md-mailman.stormreply.com>,
        NXP Linux Team
	<linux-imx@....com>,
        <linux-amlogic@...ts.infradead.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-renesas-soc@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <alsa-devel@...a-project.org>,
        <linux-sound@...r.kernel.org>
Subject: Re: [PATCH] clk: constify the of_phandle_args argument of
 of_clk_provider

On Thu, Feb 08, 2024 at 05:37:10PM +0100, Krzysztof Kozlowski wrote:
> None of the implementations of the get() and get_hw() callbacks of
> "struct of_clk_provider" modify the contents of received of_phandle_args
> pointer.  They treat it as read-only variable used to find the clock to
> return.  Make obvious that implementations are not supposed to modify
> the of_phandle_args, by making it a pointer to const.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/clk/clk-lochnagar.c                   |  2 +-

For the Lochnagar bits:

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles