linux-kernel - Re: [RFC PATCH v1 01/28] riscv: abstract envcfg CSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240212-cf2c44241bfd5e942a4e3752@orel>
Date: Mon, 12 Feb 2024 11:23:52 +0100
From: Andrew Jones <ajones@...tanamicro.com>
To: debug@...osinc.com
Cc: rick.p.edgecombe@...el.com, broonie@...nel.org, Szabolcs.Nagy@....com, 
	kito.cheng@...ive.com, keescook@...omium.org, paul.walmsley@...ive.com, 
	palmer@...belt.com, conor.dooley@...rochip.com, cleger@...osinc.com, 
	atishp@...shpatra.org, alex@...ti.fr, bjorn@...osinc.com, alexghiti@...osinc.com, 
	corbet@....net, aou@...s.berkeley.edu, oleg@...hat.com, 
	akpm@...ux-foundation.org, arnd@...db.de, ebiederm@...ssion.com, shuah@...nel.org, 
	brauner@...nel.org, guoren@...nel.org, samitolvanen@...gle.com, evan@...osinc.com, 
	xiao.w.wang@...el.com, apatel@...tanamicro.com, mchitale@...tanamicro.com, 
	waylingii@...il.com, greentime.hu@...ive.com, heiko@...ech.de, jszhang@...nel.org, 
	shikemeng@...weicloud.com, david@...hat.com, charlie@...osinc.com, 
	panqinglin2020@...as.ac.cn, willy@...radead.org, vincent.chen@...ive.com, 
	andy.chiu@...ive.com, gerg@...nel.org, jeeheng.sia@...rfivetech.com, 
	mason.huo@...rfivetech.com, ancientmodern4@...il.com, mathis.salmen@...sal.de, 
	cuiyunhui@...edance.com, bhe@...hat.com, chenjiahao16@...wei.com, ruscur@...sell.cc, 
	bgray@...ux.ibm.com, alx@...nel.org, baruch@...s.co.il, zhangqing@...ngson.cn, 
	catalin.marinas@....com, revest@...omium.org, josh@...htriplett.org, joey.gouly@....com, 
	shr@...kernel.io, omosnace@...hat.com, ojeda@...nel.org, jhubbard@...dia.com, 
	linux-doc@...r.kernel.org, linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-mm@...ck.org, linux-arch@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [RFC PATCH v1 01/28] riscv: abstract envcfg CSR

On Wed, Jan 24, 2024 at 10:21:26PM -0800, debug@...osinc.com wrote:
> From: Deepak Gupta <debug@...osinc.com>
> 
> This patch abstracts envcfg CSR in kernel (as is done for other homonyn
> CSRs). CSR_ENVCFG is used as alias for CSR_SENVCFG or CSR_MENVCFG depending
> on how kernel is compiled.
> 
> Additionally it changes CBZE enabling to start using CSR_ENVCFG instead of
> CSR_SENVCFG.
> 
> Signed-off-by: Deepak Gupta <debug@...osinc.com>
> ---
>  arch/riscv/include/asm/csr.h   | 2 ++
>  arch/riscv/kernel/cpufeature.c | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/include/asm/csr.h b/arch/riscv/include/asm/csr.h
> index 306a19a5509c..b3400517b0a9 100644
> --- a/arch/riscv/include/asm/csr.h
> +++ b/arch/riscv/include/asm/csr.h
> @@ -415,6 +415,7 @@
>  # define CSR_STATUS	CSR_MSTATUS
>  # define CSR_IE		CSR_MIE
>  # define CSR_TVEC	CSR_MTVEC
> +# define CSR_ENVCFG CSR_MENVCFG
>  # define CSR_SCRATCH	CSR_MSCRATCH
>  # define CSR_EPC	CSR_MEPC
>  # define CSR_CAUSE	CSR_MCAUSE
> @@ -439,6 +440,7 @@
>  # define CSR_STATUS	CSR_SSTATUS
>  # define CSR_IE		CSR_SIE
>  # define CSR_TVEC	CSR_STVEC
> +# define CSR_ENVCFG CSR_SENVCFG
>  # define CSR_SCRATCH	CSR_SSCRATCH
>  # define CSR_EPC	CSR_SEPC
>  # define CSR_CAUSE	CSR_SCAUSE
> diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
> index b3785ffc1570..98623393fd1f 100644
> --- a/arch/riscv/kernel/cpufeature.c
> +++ b/arch/riscv/kernel/cpufeature.c
> @@ -725,7 +725,7 @@ arch_initcall(check_unaligned_access_all_cpus);
>  void riscv_user_isa_enable(void)
>  {
>  	if (riscv_cpu_has_extension_unlikely(smp_processor_id(), RISCV_ISA_EXT_ZICBOZ))
> -		csr_set(CSR_SENVCFG, ENVCFG_CBZE);
> +		csr_set(CSR_ENVCFG, ENVCFG_CBZE);
>  }
>  
>  #ifdef CONFIG_RISCV_ALTERNATIVE
> -- 
> 2.43.0
>

Reviewed-by: Andrew Jones <ajones@...tanamicro.com>