linux-kernel - [PATCH] dm vdo: fix an assert statement in start_restoring_volume_sub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240212102526.1854044-1-harshit.m.mogalapalli@oracle.com>
Date: Mon, 12 Feb 2024 02:25:04 -0800
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: Matthew Sakai <msakai@...hat.com>, dm-devel@...ts.linux.dev,
        Mike Snitzer <snitzer@...nel.org>, Ken Raeburn <raeburn@...hat.com>,
        "J. corwin Coburn" <corwin@...lbutnet.net>,
        Thomas Jaskiewicz <tom@...kiewicz.us>, linux-kernel@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, dan.carpenter@...aro.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Subject: [PATCH] dm vdo: fix an assert statement in start_restoring_volume_sub_index()

Use "==" instead of "=" in ASSERT() statement.

Fixes: ef074a31e88e ("dm vdo: implement the volume index")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
---
This is based on static analysis with Smatch and only compile tested.
---
 drivers/md/dm-vdo/indexer/volume-index.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-vdo/indexer/volume-index.c b/drivers/md/dm-vdo/indexer/volume-index.c
index 5fe34e6c1d9b..d6526fe9bbfc 100644
--- a/drivers/md/dm-vdo/indexer/volume-index.c
+++ b/drivers/md/dm-vdo/indexer/volume-index.c
@@ -830,7 +830,7 @@ static int start_restoring_volume_sub_index(struct volume_sub_index *sub_index,
 		decode_u32_le(buffer, &offset, &header.first_list);
 		decode_u32_le(buffer, &offset, &header.list_count);
 
-		result = ASSERT(offset = sizeof(buffer),
+		result = ASSERT(offset == sizeof(buffer),
 				"%zu bytes decoded of %zu expected", offset,
 				sizeof(buffer));
 		if (result != UDS_SUCCESS)
-- 
2.39.3